Skip to content

fix: updated pf to pfcli#26

Open
dlabaj wants to merge 1 commit intopatternfly:mainfrom
dlabaj:pf-3928
Open

fix: updated pf to pfcli#26
dlabaj wants to merge 1 commit intopatternfly:mainfrom
dlabaj:pf-3928

Conversation

@dlabaj
Copy link
Copy Markdown
Contributor

@dlabaj dlabaj commented Apr 9, 2026

Updated pf command to pfcli to prevent conflict in some versions of linux and mac os.

Summary by CodeRabbit

  • Chores
    • Updated CLI command alias from pf to pfcli. Installation instructions have been updated to reflect the new command naming convention and help documentation.

@dlabaj dlabaj self-assigned this Apr 9, 2026
@dlabaj dlabaj added the bug Something isn't working label Apr 9, 2026
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Apr 9, 2026
@dlabaj dlabaj moved this from Needs triage to PR Review in PatternFly Issues Apr 9, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Walkthrough

The changes update the CLI command alias name from pf to pfcli across the package configuration and installation script, while maintaining the same executable reference to ./dist/cli.js.

Changes

Cohort / File(s) Summary
CLI Alias Update
package.json, scripts/install.sh
Updated CLI command alias name from pf to pfcli in package bin entry and corresponding installation script instructions, maintaining reference to the same executable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: renaming the CLI command alias from 'pf' to 'pfcli' across package.json and installation script.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@scripts/install.sh`:
- Line 251: The installer output contains a typo in the printf string: it prints
"pattenfly-cli" instead of the correct "patternfly-cli"; update the printf call
that emits 'alternatively you can use the alias "pfcli" instead of
"pattenfly-cli"' to use the correct product name "patternfly-cli" so user-facing
guidance is accurate.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a64fd7df-2c23-4444-83d0-db50ead2b154

📥 Commits

Reviewing files that changed from the base of the PR and between 3d0a15c and 672dbc9.

📒 Files selected for processing (2)
  • package.json
  • scripts/install.sh

printf ' patternfly-cli --help\n'
printf '\n'
printf 'alternatively you can use the alias "pf" instead of "pattenfly-cli"\n'
printf 'alternatively you can use the alias "pfcli" instead of "pattenfly-cli"\n'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in installer output string.

Line 251 says pattenfly-cli (missing r). This is user-facing install guidance and should be corrected.

Suggested fix
-  printf 'alternatively you can use the alias "pfcli" instead of "pattenfly-cli"\n'
+  printf 'Alternatively, you can use the alias "pfcli" instead of "patternfly-cli"\n'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
printf 'alternatively you can use the alias "pfcli" instead of "pattenfly-cli"\n'
printf 'Alternatively, you can use the alias "pfcli" instead of "patternfly-cli"\n'
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@scripts/install.sh` at line 251, The installer output contains a typo in the
printf string: it prints "pattenfly-cli" instead of the correct
"patternfly-cli"; update the printf call that emits 'alternatively you can use
the alias "pfcli" instead of "pattenfly-cli"' to use the correct product name
"patternfly-cli" so user-facing guidance is accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: PR Review

Development

Successfully merging this pull request may close these issues.

1 participant